ci: Add concurrency groups to all workflows#599
Conversation
PierreQuinton
added
the
cc: ci
github-actions
bot
changed the title
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
There was a problem hiding this comment.
LGTM.
- If the github.ref is a version tag, we should never have this action running twice on the same github.ref, so this will have no effect.
- If the github.ref is main, and we have multiple pushes to main in a short amount of time, we want to build sequentially, and cancel some of the jobs if there are too many. We want the last push to lead to a documentation building, which should be the case with this.
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
LGTM. We want to cancel in-progress to avoid having to wait for previous checks to finish running before running new checks.
.github/workflows/claude.yml
Outdated
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
There was a problem hiding this comment.
This workflow is a bit weird because it runs every time an issue comment is even posted (to check for a tag to claude). So I think that we want those workflows to be able to run concurrently. So I would remove the concurrency group entirely.
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: false |
.github/workflows/release.yml
Outdated
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
There was a problem hiding this comment.
I think we should never have this workflow triggered concurrently (it would require to publish two releases in less than 3 minutes). But if this ever happens, I don't think we want to skip any job, so I think we should remove the concurrency group here and let everything run.
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: false |
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
LGTM. We only care about the latest change to the labels taking effect on the title.
|
/opencode please review this. |
|
@PierreQuinton it doesn't seem to work, or maybe we have to wait a bit more. Apparently the job was skipped so maybe the condition is wrong. |
|
@claude the command to call opencode didn't work. Find why. |
|
Claude finished @ValerianRey's task in 3m 6s —— View job Investigation: Why
|
|
/opencode Please review this. |
Co-authored-by: ValerianRey <ValerianRey@users.noreply.github.com>
|
Applied the suggested changes - removed concurrency groups from |
|
User opencode-agent[bot] does not have write permissions |
|
@PierreQuinton Apparently opencode can commit (which I think is a good thing, I wanted to activate that for claude too). There seems to be a missing write permission for something it wanted to do. I think we should give it and try out. |
|
I'm pretty sure we can configure 2 agaents (build or plan) so that one doesn't/cannot change and the other one can. We could assign the reviews to plan and the changes to build. We could have separate commands for that. |
That would be really nice. |
|
/opencode:Plan Can you review this and suggest suggestions if needed? |
|
The implementation looks correct. Based on the review comments and current state: ✓ Correct implementations:
The current state correctly implements the reviewer's suggestions. No changes needed. |
2 participants
No description provided.